chore: Upgrade node version & add HTTP proxy configuration #753
Conversation
- Upgrade base Node.js image from v20 to v22-alpine3.20 - Upgrade Alpine from 3.19 to 3.20 for both Node and Go base images - Add NODE_USE_ENV_PROXY=1 environment variable to enable automatic proxy configuration - Document HTTP proxy environment variables (HTTP_PROXY, HTTPS_PROXY, NO_PROXY) This enables Sourcebot to work in enterprise environments that require HTTP/HTTPS proxies for external access. Node.js v22 natively supports proxy configuration via environment variables when NODE_USE_ENV_PROXY is enabled. Co-authored-by: brendan <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis pull request implements HTTP proxy configuration support by upgrading Docker base images to versions supporting Node.js proxy environment variables (node:22 and alpine3.20), enabling the NODE_USE_ENV_PROXY flag in the runner stage, and documenting the HTTP_PROXY, HTTPS_PROXY, NO_PROXY, and NODE_USE_ENV_PROXY environment variables. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
brendan-kellam
changed the title
This comment has been minimized.
This comment has been minimized.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@Dockerfile`:
- Around line 18-19: Update the Node.js base image in the Dockerfile by
replacing the FROM line that currently reads "FROM node:22-alpine3.20" with a
tag that includes Node v22.21.0 or later (e.g., "FROM node:22.21.0-alpine3.20"
or a newer patch), so the NODE_USE_ENV_PROXY feature is available; leave the
golang FROM ("FROM golang:1.23.4-alpine3.20") unchanged.
In `@docs/docs/configuration/environment-variables.mdx`:
- Around line 40-47: The Markdown table under "HTTP Proxy Configuration" uses
double-leading pipes which breaks rendering; update the table by replacing the
leading "||" with a single "|" on every table line (header, separator, and data
rows) so standard Markdown table syntax is used, keeping the existing column
headings and cell content (e.g., variable names like HTTP_PROXY, HTTPS_PROXY,
NO_PROXY, NODE_USE_ENV_PROXY) unchanged.
Co-authored-by: brendan <[email protected]>
…port Co-authored-by: brendan <[email protected]>
brendan-kellam
deleted the
cursor/SOU-226-http-proxy-configuration-2375
branch
Upgrade Node.js to v22 LTS and enable HTTP proxy support via environment variables.
This resolves the
fetch failederror when Sourcebot attempts to access external services like GitLab through an HTTP/HTTPS proxy, as Node.js v22+ is required for automatic proxy detection usingHTTP_PROXY,HTTPS_PROXY, andNO_PROXY.Fixes #751
Summary by CodeRabbit
New Features
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.